Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Calculate & Store MAC stats #30439

Merged
merged 4 commits into from
Oct 4, 2023
Merged

chore: Calculate & Store MAC stats #30439

merged 4 commits into from
Oct 4, 2023

Conversation

KevLehman
Copy link
Contributor

NBJ-172
NBJ-244

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 45332c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/model-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #30439 (d91ad2e) into new/nbj-visitor-disabling (fa783fb) will increase coverage by 0.02%.
Report is 1 commits behind head on new/nbj-visitor-disabling.
The diff coverage is n/a.

❗ Current head d91ad2e differs from pull request most recent head 45332c7. Consider uploading reports for the commit 45332c7 to get more accurate results

Impacted file tree graph

@@                      Coverage Diff                      @@
##           new/nbj-visitor-disabling   #30439      +/-   ##
=============================================================
+ Coverage                      50.12%   50.15%   +0.02%     
=============================================================
  Files                            774      774              
  Lines                          14456    14456              
  Branches                        2613     2613              
=============================================================
+ Hits                            7246     7250       +4     
+ Misses                          6807     6801       -6     
- Partials                         403      405       +2
Flag Coverage Δ
e2e 48.50% <ø> (+0.03%) ⬆️
unit 60.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@debdutdeb debdutdeb changed the title new: Calculate & Store MAC stats chore: Calculate & Store MAC stats Sep 19, 2023
@KevLehman KevLehman force-pushed the new/nbj-visitor-disabling branch from 7af80bb to eeba96f Compare September 20, 2023 19:07
@KevLehman KevLehman added this to the 6.5.0 milestone Oct 3, 2023
@ggazzo ggazzo marked this pull request as ready for review October 3, 2023 22:20
@ggazzo ggazzo requested review from a team as code owners October 3, 2023 22:20
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 3, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 4, 2023
@ggazzo ggazzo merged commit 1d2c83b into new/nbj-visitor-disabling Oct 4, 2023
7 of 8 checks passed
@ggazzo ggazzo deleted the new/nbj-stats branch October 4, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
squad: omnichannel stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.5
Development

Successfully merging this pull request may close these issues.
3 participants
@KevLehman @ggazzo @MarcosSpessatto